kszucs commented on a change in pull request #7334:
URL: https://github.com/apache/arrow/pull/7334#discussion_r434773060
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -707,15 +707,14 @@ endif()
# - Gandiva has a compile-time (header-only) dependency on Boost, not runtime.
# - Tests need Boost at runtime.
# - S3FS and Flight benchmarks need Boost at runtime.
+
if(ARROW_BUILD_INTEGRATION
OR ARROW_BUILD_TESTS
OR (ARROW_FLIGHT AND ARROW_BUILD_BENCHMARKS)
OR (ARROW_S3 AND ARROW_BUILD_BENCHMARKS)
OR ARROW_GANDIVA
OR (ARROW_WITH_THRIFT AND Thrift_SOURCE STREQUAL "BUNDLED")
- OR (ARROW_PARQUET
- AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU"
- AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.9"))
+ OR ARROW_PARQUET)
Review comment:
```
In file included from /usr/local/include/thrift/TApplicationException.h:23,
from /arrow/cpp/src/parquet/thrift_internal.h:36,
from /arrow/cpp/src/parquet/column_reader.cc:47:
/usr/local/include/thrift/Thrift.h:45:10: fatal error:
boost/utility/enable_if.hpp: No such file or directory
#include <boost/utility/enable_if.hpp>
```
Seems like the parquet headers require boost headers as a transitive
dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
