pitrou commented on a change in pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#discussion_r435383262



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1367,7 +1370,7 @@ endif()
 # ----------------------------------------------------------------------
 # mimalloc - Cross-platform high-performance allocator, from Microsoft
 
-if(ARROW_MIMALLOC)
+macro(build_mimalloc)
   message(STATUS "Building (vendored) mimalloc from source")
   # We only use a vendored mimalloc as we want to control its build options.

Review comment:
       Is this comment obsolete? Does conda-forge uses the same build options 
as we do?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to