wesm opened a new pull request #7352: URL: https://github.com/apache/arrow/pull/7352
There is a lot of code in bit_util.h that is seldom used compared to certain common utilities like `BitUtil::BytesForBits`. This moves everything outside of the `BitUtil` namespace to different headers. You can see by the frequency of includes that this makes sense so that compilation units that only need some simple bit utilities are not including a lot of header code that they never use ``` $ grep -R bit_util.h ../src/ | wc -l 68 $ grep -R bitmap.h ../src/ | wc -l 7 $ grep -R bitmap_ops.h ../src/ | wc -l 15 $ grep -R bitmap_reader.h ../src/ | wc -l 9 $ grep -R bitmap_writer.h ../src/ | wc -l 6 ``` This doesn't seem to affect aggregate compilation time very much but at minimum makes the code easier to navigate (in my opinion, at least). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
