[GitHub] [arrow] kou edited a comment on pull request #7363: ARROW-9051: [GLib] Refer Array related objects from Array

[GitBox]

kou edited a comment on pull request #7363:
URL: https://github.com/apache/arrow/pull/7363#issuecomment-639960291


   Sorry. This will be big to review.
   This fixes recent test failure like 
https://github.com/apache/arrow/runs/737152388 : 
   
   ```text
   2020-06-04T04:42:11.7272962Z Failure: test_new(TestStructArray)
   2020-06-04T04:42:11.7278250Z /arrow/c_glib/test/test-struct-array.rb:45:in 
`test_new'
   2020-06-04T04:42:11.7280011Z      42:       Arrow::Int8Array.new(2, 
Arrow::Buffer.new([-29, 2].pack("C*")), nulls, 0),
   2020-06-04T04:42:11.7280698Z      43:       Arrow::BooleanArray.new(2, 
Arrow::Buffer.new([0b01].pack("C*")), nulls, 0),
   2020-06-04T04:42:11.7281159Z      44:     ]
   2020-06-04T04:42:11.7281643Z   => 45:     assert_equal(struct_array1,
   2020-06-04T04:42:11.7282232Z      46:                  
Arrow::StructArray.new(data_type,
   2020-06-04T04:42:11.7290723Z      47:                                        
 3,
   2020-06-04T04:42:11.7291310Z      48:                                        
 children,
   2020-06-04T04:42:11.7292404Z <#<Arrow::StructArray:0x2b94c20 ptr=0x247d820 
-- is_valid:
   2020-06-04T04:42:11.7292879Z   [
   2020-06-04T04:42:11.7293137Z     true,
   2020-06-04T04:42:11.7293502Z     true,
   2020-06-04T04:42:11.7293785Z     false
   2020-06-04T04:42:11.7294015Z   ]
   2020-06-04T04:42:11.7294639Z -- child 0 type: int8
   2020-06-04T04:42:11.7295527Z   [
   2020-06-04T04:42:11.7296462Z     -29,
   2020-06-04T04:42:11.7297060Z     2
   2020-06-04T04:42:11.7298316Z   ]
   2020-06-04T04:42:11.7298708Z -- child 1 type: bool
   2020-06-04T04:42:11.7299354Z   [
   2020-06-04T04:42:11.7299501Z     true,
   2020-06-04T04:42:11.7299764Z     false
   2020-06-04T04:42:11.7299872Z   ]>> expected but was
   2020-06-04T04:42:11.7300715Z <#<Arrow::StructArray:0x291fd78 ptr=0x246d040 
-- is_valid:
   2020-06-04T04:42:11.7300848Z   [
   2020-06-04T04:42:11.7300948Z     true,
   2020-06-04T04:42:11.7301047Z     true,
   2020-06-04T04:42:11.7301135Z     false
   2020-06-04T04:42:11.7301234Z   ]
   2020-06-04T04:42:11.7301472Z -- child 0 type: int8
   2020-06-04T04:42:11.7301557Z   [
   2020-06-04T04:42:11.7302241Z     -72,
   2020-06-04T04:42:11.7302558Z     -8
   2020-06-04T04:42:11.7302664Z   ]
   2020-06-04T04:42:11.7302888Z -- child 1 type: bool
   2020-06-04T04:42:11.7302997Z   [
   2020-06-04T04:42:11.7303101Z     true,
   2020-06-04T04:42:11.7303205Z     true
   2020-06-04T04:42:11.7309639Z   ]>>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org