emkornfield commented on a change in pull request #7389:
URL: https://github.com/apache/arrow/pull/7389#discussion_r437792823
##########
File path: cpp/src/arrow/util/bit_block_counter_test.cc
##########
@@ -246,5 +246,28 @@ TEST(TestBinaryBitBlockCounter, NextAndWord) {
}
}
+TEST(TestOptionalBitBlockCounter, Basics) {
+ const int64_t nbytes = 1024;
+ auto bitmap = *AllocateBitmap(nbytes * 8);
+ random_bytes(nbytes, 0, bitmap->mutable_data());
+
+ OptionalBitBlockCounter optional_counter(bitmap, 0, nbytes * 8);
+ BitBlockCounter bit_counter(bitmap->data(), 0, nbytes * 8);
+
+ while (true) {
Review comment:
I think do/while here might be more natural?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
