pitrou commented on a change in pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#discussion_r438018616
##########
File path: cpp/src/arrow/ipc/writer.h
##########
@@ -330,6 +306,11 @@ ARROW_EXPORT
Status GetRecordBatchPayload(const RecordBatch& batch, const IpcWriteOptions&
options,
IpcPayload* out);
+/// \brief Write an IPC payload to the given stream.
+/// \param[in] payload the payload to write
+/// \param[in] options options for serialization
+/// \param[out] metadata_length the length of the serialized metadata
Review comment:
The docstring is missing the `dst` parameter.
##########
File path: cpp/src/arrow/ipc/read_write_benchmark.cc
##########
@@ -153,9 +153,38 @@ static void DecodeStream(benchmark::State& state) { //
NOLINT non-const referen
state.SetBytesProcessed(int64_t(state.iterations()) * kTotalSize);
}
+static void GetRecordBatchSize(benchmark::State& state) { // NOLINT non-const
reference
Review comment:
I don't think it makes sense to maintain those benchmarks in the
codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
