kou commented on a change in pull request #7397:
URL: https://github.com/apache/arrow/pull/7397#discussion_r438421515
##########
File path: cpp/cmake_modules/FindgRPCAlt.cmake
##########
@@ -100,19 +109,35 @@ if(gRPCAlt_FOUND)
PROPERTIES IMPORTED_LOCATION "${GRPC_GRPC_LIB}"
INTERFACE_INCLUDE_DIRECTORIES
"${GRPC_INCLUDE_DIR}")
- add_library(gRPC::grpc++ UNKNOWN IMPORTED)
- set_target_properties(gRPC::grpc++
- PROPERTIES IMPORTED_LOCATION "${GRPC_GRPCPP_LIB}"
- INTERFACE_INCLUDE_DIRECTORIES
"${GRPC_INCLUDE_DIR}")
+ set(_GRPCPP_LINK_LIBRARIES "gRPC::grpc;gRPC::gpr")
if(GRPC_ADDRESS_SORTING_LIB)
# Address sorting is optional and not always required.
add_library(gRPC::address_sorting UNKNOWN IMPORTED)
set_target_properties(gRPC::address_sorting
PROPERTIES IMPORTED_LOCATION
"${GRPC_ADDRESS_SORTING_LIB}"
INTERFACE_INCLUDE_DIRECTORIES
"${GRPC_INCLUDE_DIR}")
+ set(_GRPCPP_LINK_LIBRARIES
"${_GRPCPP_LINK_LIBRARIES};gRPC::address_sorting")
+ endif()
+
+ if(GRPC_UPB_LIB)
+ # upb is used by recent gRPC versions
+ add_library(gRPC::upb UNKNOWN IMPORTED)
+ set_target_properties(gRPC::upb
+ PROPERTIES IMPORTED_LOCATION
"${GRPC_ADDRESS_SORTING_LIB}"
Review comment:
```suggestion
PROPERTIES IMPORTED_LOCATION "${GRPC_UPB_LIB}"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
