pitrou commented on a change in pull request #7398:
URL: https://github.com/apache/arrow/pull/7398#discussion_r438929219
##########
File path: python/pyarrow/_flight.pyx
##########
@@ -177,6 +185,16 @@ cdef class FlightUnavailableError(FlightError,
ArrowException):
return MakeFlightError(CFlightStatusUnavailable, tobytes(str(self)),
self.extra_info)
+
+class FlightWriteSizeExceededError(OSError, ArrowException):
Review comment:
I'm not sure I get the point of `OSError` here. I would expect
`ArrowInvalid`.
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -73,6 +91,16 @@ class ARROW_FLIGHT_EXPORT FlightClientOptions {
std::string private_key;
/// \brief A list of client middleware to apply.
std::vector<std::shared_ptr<ClientMiddlewareFactory>> middleware;
+ /// \brief A soft limit on the number of bytes to write when sending
+ /// Arrow data to a server.
Review comment:
For a single message / batch, right?
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -73,6 +91,16 @@ class ARROW_FLIGHT_EXPORT FlightClientOptions {
std::string private_key;
/// \brief A list of client middleware to apply.
std::vector<std::shared_ptr<ClientMiddlewareFactory>> middleware;
+ /// \brief A soft limit on the number of bytes to write when sending
+ /// Arrow data to a server.
+ ///
+ /// Used to help limit server memory consumption. Only enabled if
+ /// positive. When enabled, \a FlightStreamWriter.Write* may yield a
Review comment:
Why the `\a`s?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
