wesm commented on a change in pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#discussion_r439418114
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -37,26 +37,108 @@ struct AsciiLength {
}
};
-struct AsciiUpper {
- // XXX: the Scalar codegen path passes template arguments that are unused
- template <typename... Ignored>
- static std::string Call(KernelContext*, const util::string_view& val) {
- std::string result = val.to_string();
- std::transform(result.begin(), result.end(), result.begin(),
- [](unsigned char c) { return std::toupper(c); });
- return result;
+using TransformFunc = std::function<void(const uint8_t*, int64_t, uint8_t*)>;
+
+void StringDataTransform(KernelContext* ctx, const ExecBatch& batch,
Review comment:
OK
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##########
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/benchmark_util.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+
+namespace arrow {
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+static void UnaryStringBenchmark(benchmark::State& state, const std::string&
func_name) {
+ const int64_t array_length = 1 << 20;
+ const int64_t value_min_size = 0;
+ const int64_t value_max_size = 32;
+ const double null_probability = 0.01;
+ random::RandomArrayGenerator rng(kSeed);
+
+ auto values =
+ rng.String(array_length, value_min_size, value_max_size,
null_probability);
+ for (auto _ : state) {
+ ABORT_NOT_OK(CallFunction(func_name, {values}));
+ }
+ state.SetItemsProcessed(state.iterations() * array_length);
Review comment:
Yes, will add
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
