cool-RR commented on pull request #7416: URL: https://github.com/apache/arrow/pull/7416#issuecomment-643355049
I understand. I personally hate `from None`, and I think that when people are debugging they have a very different mindset than when they are writing code. When you're debugging, and you get a very limited amount of information that may have been copy-pasted in an email by a non-technical person, you're very desperate for the information. In this case, I would have wanted to see the `ArrowSources.find(src)` traceback. I would maybe get a hint on what happened. If it's a dead end for exploration, I at least want to know its content before I rule it out as a dead end. Another issue is that some error-reporting systems show not only the traceback, but all the local variables on each of these levels. These supposedly irrelevant levels could have variables that make it clearer what this exception is about. Below is a list of lines in arrow where you might want to change to either a `raise new from old` line or a `raise new from None` line. If you'd like me to change to a `raise new from old` on any of these, let me know and I'll create a PR: ``` dev/archery/archery/bot.py: 57 dev/archery/archery/cli.py: 94 dev/archery/archery/cli.py: 768 dev/archery/archery/cli.py: 773 dev/archery/archery/docker.py: 131 dev/archery/archery/integration/util.py: 148 dev/archery/archery/lang/python.py: 180 dev/merge_arrow_pr.py: 91 dev/merge_arrow_pr.py: 540 dev/tasks/crossbow.py: 351 dev/tasks/crossbow.py: 651 dev/tasks/crossbow.py: 817 dev/tasks/crossbow.py: 1137 python/pyarrow/pandas_compat.py: 416 python/pyarrow/pandas_compat.py: 420 python/pyarrow/pandas_compat.py: 426 python/pyarrow/pandas_compat.py: 566 python/pyarrow/tests/test_flight.py: 77 python/pyarrow/tests/test_hdfs.py: 46 python/pyarrow/tests/test_hdfs.py: 401 run-cmake-format.py: 90 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
