bkietz commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r439514082
##########
File path: cpp/src/arrow/util/checked_cast.h
##########
@@ -39,11 +40,11 @@ inline OutputType checked_cast(InputType&& value) {
}
template <class T, class U>
-std::shared_ptr<T> checked_pointer_cast(const std::shared_ptr<U>& r) noexcept {
+std::shared_ptr<T> checked_pointer_cast(std::shared_ptr<U> r) noexcept {
Review comment:
I can add an rvalue overload of checked_pointer_cast as the standard
does, but my understanding is that since we're always taking ownership of `r`
then the copy may as well take place in argument initialization, as with
`modernize-pass-by-value`
##########
File path: cpp/src/arrow/dataset/test_util.h
##########
@@ -251,6 +251,15 @@ class JSONRecordBatchFileFormat : public FileFormat {
SchemaResolver resolver_;
};
+inline static std::vector<FileSource> SourcesFromPaths(
Review comment:
Okay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
