wesm commented on a change in pull request #7420:
URL: https://github.com/apache/arrow/pull/7420#discussion_r439523904



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -45,6 +45,12 @@ namespace compute {
 ARROW_EXPORT
 Result<Datum> Add(const Datum& left, const Datum& right, ExecContext* ctx = 
NULLPTR);
 
+// TODO(kszucs): create add/arithmetic options to select between the 
underlying kernels
+// and remove these functions

Review comment:
       Yes, let's do it in this patch rather than introducing these new APIs




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to