kou commented on a change in pull request #7436:
URL: https://github.com/apache/arrow/pull/7436#discussion_r440463018
##########
File path: python/manylinux1/scripts/build_boost.sh
##########
@@ -16,12 +16,12 @@
# specific language governing permissions and limitations
# under the License.
-BOOST_VERSION=1.68.0
+BOOST_VERSION=1.73.0
BOOST_VERSION_UNDERSCORE=${BOOST_VERSION//\./_}
NCORES=$(($(grep -c ^processor /proc/cpuinfo) + 1))
-curl -sL
https://sourceforge.net/projects/boost/files/boost/${BOOST_VERSION}/boost_${BOOST_VERSION_UNDERSCORE}.tar.gz
-o /boost_${BOOST_VERSION_UNDERSCORE}.tar.gz
-tar xf boost_${BOOST_VERSION_UNDERSCORE}.tar.gz
+curl -sL
https://dl.bintray.com/boostorg/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDERSCORE}.tar.bz2
-o /boost_${BOOST_VERSION_UNDERSCORE}.tar.bz2
Review comment:
Could you keep sourceforge.net URL?
Because dl.bintray.com/boostorg/ will reach limitation constantly. See also:
https://github.com/boostorg/boost/issues/299
##########
File path: cpp/cmake_modules/FindgRPCAlt.cmake
##########
@@ -169,13 +169,14 @@ if(gRPCAlt_FOUND)
INTERFACE_INCLUDE_DIRECTORIES
"${GRPC_INCLUDE_DIR}")
add_library(gRPC::grpc UNKNOWN IMPORTED)
- set_target_properties(gRPC::grpc
Review comment:
Adding `ZLIB::ZLIB` and `c-ares::cares` to `INTERFACE_LINK_LIBRARIES` is
reasonable because `libgrpc++.a` depends on them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
