fsaintjacques commented on a change in pull request #7440:
URL: https://github.com/apache/arrow/pull/7440#discussion_r440826772
##########
File path: cpp/src/arrow/dataset/discovery_test.cc
##########
@@ -364,6 +364,16 @@ TEST_F(FileSystemDatasetFactoryTest,
FilenameNotPartOfPartitions) {
}
}
+TEST_F(FileSystemDatasetFactoryTest, UnparseablePartitionExpression) {
+ auto s = schema({field("first", int32()), field("second", int32())});
+ factory_options_.partitioning = std::make_shared<HivePartitioning>(s);
+
+ selector_.recursive = true;
+ MakeFactory({fs::File("first=one/file.parquet")});
+
+ ASSERT_RAISES(Invalid, factory_->Finish().status());
Review comment:
Can you add some cases that shouldn't fail just in case, e.g.
```
""
"first=1/file.parquet"
"first=1/second=2/file.parquet"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
