pitrou commented on a change in pull request #7452: URL: https://github.com/apache/arrow/pull/7452#discussion_r442127449
########## File path: cpp/cmake_modules/Findutf8proc.cmake ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +if(UTF8PROC_ROOT) + find_library( + UTF8PROC_LIB + NAMES utf8proc + "${CMAKE_SHARED_LIBRARY_PREFIX}utf8proc${CMAKE_SHARED_LIBRARY_SUFFIX}" + PATHS ${UTF8PROC_ROOT} + PATH_SUFFIXES ${LIB_PATH_SUFFIXES} + NO_DEFAULT_PATH) + find_path(UTF8PROC_INCLUDE_DIR + NAMES utf8proc.h + PATHS ${UTF8PROC_ROOT} + NO_DEFAULT_PATH + PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES}) + +else() + find_library( + UTF8PROC_LIB + NAMES utf8proc + "${CMAKE_SHARED_LIBRARY_PREFIX}utf8proc${CMAKE_SHARED_LIBRARY_SUFFIX}" + PATH_SUFFIXES ${LIB_PATH_SUFFIXES}) + find_path(UTF8PROC_INCLUDE_DIR NAMES utf8proc.h PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES}) +endif() + +find_package_handle_standard_args(utf8proc REQUIRED_VARS UTF8PROC_LIB UTF8PROC_INCLUDE_DIR) + +# CMake 3.2 does uppercase the FOUND variable +if(UTF8PROC_FOUND OR utf8proc_FOUND) + set(utf8proc_FOUND TRUE) + add_library(utf8proc::utf8proc UNKNOWN IMPORTED) Review comment: Why "UNKNOWN"? ########## File path: cpp/thirdparty/versions.txt ########## @@ -49,6 +49,7 @@ ARROW_THRIFT_BUILD_VERSION=0.12.0 ARROW_THRIFT_BUILD_MD5_CHECKSUM=3deebbb4d1ca77dd9c9e009a1ea02183 ARROW_ZLIB_BUILD_VERSION=1.2.11 ARROW_ZSTD_BUILD_VERSION=v1.4.5 +ARROW_UTF8PROC_BUILD_VERSION=v2.5.0 Review comment: Can you keep this file in alphabetical order? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
