nealrichardson commented on a change in pull request #7478:
URL: https://github.com/apache/arrow/pull/7478#discussion_r442905880
##########
File path: r/R/compute.R
##########
@@ -58,13 +58,12 @@ scalar_aggregate <- function(FUN, ..., na.rm = FALSE) {
if (FUN %in% c("mean", "sum")) {
# Arrow sum/mean function always drops NAs so handle that here
# https://issues.apache.org/jira/browse/ARROW-9054
- return(Scalar$create(NA_integer_, type = a$type))
+ return(Scalar$create(NA_real_))
}
}
- if (inherits(a$type, "Boolean")) {
- # Bool sum/mean not implemented so cast to int
- # https://issues.apache.org/jira/browse/ARROW-9055
+ if (inherits(a$type, "Boolean") && FUN %in% "minmax") {
+ # Bool minmax not implemented so cast to int
Review comment:
👍 I removed this special case altogether now, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
