wesm commented on pull request #7525:
URL: https://github.com/apache/arrow/pull/7525#issuecomment-648235922
Here's what I see in the sort benchmarks with this patch compared with
7ed698b94, the patch right before the visitor_inline.h changes
```
benchmark baseline
contender change % counters
14 SortToIndicesInt64Count/32768/10000/min_time:1.000 1.604 GiB/sec
1.888 GiB/sec 17.699 {'iterations': 72619, 'null_percent': 0.01}
3 SortToIndicesInt64Compare/32768/1/min_time:1.000 3.926 GiB/sec
4.186 GiB/sec 6.625 {'iterations': 187121, 'null_percent': 100.0}
8 SortToIndicesInt64Compare/1048576/1/min_time:1.000 5.012 GiB/sec
5.182 GiB/sec 3.399 {'iterations': 7178, 'null_percent': 100.0}
1 SortToIndicesInt64Count/8388608/1/min_time:1.000 4.460 GiB/sec
4.588 GiB/sec 2.886 {'iterations': 803, 'null_percent': 100.0}
9 SortToIndicesInt64Count/32768/1/min_time:1.000 3.937 GiB/sec
4.047 GiB/sec 2.809 {'iterations': 180351, 'null_percent': 100.0}
12 SortToIndicesInt64Count/1048576/1/min_time:1.000 4.953 GiB/sec
5.082 GiB/sec 2.617 {'iterations': 7119, 'null_percent': 100.0}
10 SortToIndicesInt64Compare/8388608/1/min_time:1.000 4.496 GiB/sec
4.610 GiB/sec 2.533 {'iterations': 808, 'null_percent': 100.0}
4 SortToIndicesInt64Compare/32768/0/min_time:1.000 141.060 MiB/sec
143.991 MiB/sec 2.078 {'iterations': 6473, 'null_percent': 0.0}
15 SortToIndicesInt64Compare/32768/2/min_time:1.000 231.389 MiB/sec
232.690 MiB/sec 0.562 {'iterations': 10364, 'null_percent': 50.0}
5 SortToIndicesInt64Compare/32768/10000/min_time:1.000 140.567 MiB/sec
140.746 MiB/sec 0.127 {'iterations': 6253, 'null_percent': 0.01}
13 SortToIndicesInt64Count/32768/2/min_time:1.000 765.674 MiB/sec
761.830 MiB/sec -0.502 {'iterations': 34058, 'null_percent': 50.0}
7 SortToIndicesInt64Compare/32768/100/min_time:1.000 141.645 MiB/sec
139.367 MiB/sec -1.609 {'iterations': 6318, 'null_percent': 1.0}
11 SortToIndicesInt64Compare/32768/10/min_time:1.000 150.378 MiB/sec
143.670 MiB/sec -4.461 {'iterations': 6717, 'null_percent': 10.0}
2 SortToIndicesInt64Count/32768/0/min_time:1.000 2.139 GiB/sec
2.042 GiB/sec -4.574 {'iterations': 96456, 'null_percent': 0.0}
6 SortToIndicesInt64Count/32768/100/min_time:1.000 1.571 GiB/sec
1.343 GiB/sec -14.525 {'iterations': 71534, 'null_percent': 1.0}
0 SortToIndicesInt64Count/32768/10/min_time:1.000 1.532 GiB/sec
1.098 GiB/sec -28.306 {'iterations': 69953, 'null_percent': 10.0}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
