nealrichardson commented on a change in pull request #7524:
URL: https://github.com/apache/arrow/pull/7524#discussion_r444311774



##########
File path: r/R/table.R
##########
@@ -202,7 +210,27 @@ Table$create <- function(..., schema = NULL) {
 
 #' @export
 as.data.frame.Table <- function(x, row.names = NULL, optional = FALSE, ...) {
-  Table__to_dataframe(x, use_threads = option_use_threads())
+  df <- Table__to_dataframe(x, use_threads = option_use_threads())
+
+  if (!is.null(r_metadata <- x$metadata$r)) {
+    r_metadata <- .arrow_unserialize(r_metadata)
+
+    df_metadata <- r_metadata[[1L]]

Review comment:
       IMO using a named list would be clearer than relying on position in an 
unnamed list

##########
File path: r/src/table.cpp
##########
@@ -172,11 +172,20 @@ std::shared_ptr<arrow::Table> Table__from_dots(SEXP lst, 
SEXP schema_sxp) {
   std::shared_ptr<arrow::Schema> schema;
 
   if (Rf_isNull(schema_sxp)) {
-    // infer the schema from the ...
+    // infer the schema from the `...`

Review comment:
       I wonder if this whole block of code should be factored out so it can be 
used whether you're creating a Table or a RecordBatch. It's the same either 
way: return a Schema corresponding to the data given.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to