jacques-n commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-650227890


   
   > 1. We are package-hacking `org.apache.arrow.memory` in module 
`arrow-dataset`.
   >    Yes `Ownerships.java` uses some hacks, so I've removed the class in 
latest commits (the whole class is not necessary for current use case). Now 
only `NativeUnderlyingMemory.java` is still in the package 
`org.apache.arrow.memory`.
   
   We need to avoid this entirely. If you need some functionality, let's figure 
out what should be exposed. BaseAllocator should not be referenced.
   
   > 2. We lose java native heap caps.
   >    Can we clarify this? I think the explanation can be either we lose caps 
from JVM direct memory, or we lose caps from BufferAllocator. For the latter 
one I think buffers are already registered to allocator.
   
   JVM should respect the max direct memory setting. I added more comments on 
your other comment to that end.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to