liyafan82 commented on a change in pull request #7544:
URL: https://github.com/apache/arrow/pull/7544#discussion_r448168519
##########
File path: cpp/src/arrow/ipc/metadata_internal.h
##########
@@ -198,7 +198,7 @@ Status WriteDictionaryMessage(
const int64_t id, const int64_t length, const int64_t body_length,
const std::shared_ptr<const KeyValueMetadata>& custom_metadata,
const std::vector<FieldMetadata>& nodes, const
std::vector<BufferMetadata>& buffers,
- const IpcWriteOptions& options, std::shared_ptr<Buffer>* out);
+ const IpcWriteOptions& options, std::shared_ptr<Buffer>* out, bool
isDelta);
Review comment:
Sounds reasonable. I have revised the code to place it after the id
argument. (I have also revised other APIs accordingly, to make it consistent)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
