wesm commented on pull request #7539: URL: https://github.com/apache/arrow/pull/7539#issuecomment-653023037
@mrkn to improve the benchmark usefulness I would recommend increasing the size of the data being processed. I ran them locally and the COO benchmarks all run in less than 10 microseconds (some close to 1 microsecond) and at that speed things like destructors show up as non-trivial overhead ``` + 91.29% 0.50% arrow-tensor-co arrow-tensor-conversion-benchmark [.] arrow::Int8RowMajorTensorConversionFixture_ConvertToSparseCOOTensorInt32_Benchmark::BenchmarkCase + 91.24% 0.00% arrow-tensor-co arrow-tensor-conversion-benchmark [.] _start + 91.24% 0.00% arrow-tensor-co libc-2.27.so [.] __libc_start_main + 91.24% 0.00% arrow-tensor-co arrow-tensor-conversion-benchmark [.] main + 91.24% 0.00% arrow-tensor-co arrow-tensor-conversion-benchmark [.] benchmark::RunSpecifiedBenchmarks + 79.50% 3.05% arrow-tensor-co arrow-tensor-conversion-benchmark [.] arrow::SparseTensorImpl<arrow::SparseCOOIndex>::Make + 74.47% 2.29% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::internal::MakeSparseCOOTensorFromTensor + 74.47% 0.04% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::internal::MakeSparseTensorFromTensor + 74.33% 16.65% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::internal::(anonymous namespace)::SparseCOOTensorConverter::Convert + 25.47% 25.47% arrow-tensor-co libc-2.27.so [.] __memmove_avx_unaligned_erms + 12.64% 7.00% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::internal::ComputeRowMajorStrides + 11.35% 1.87% arrow-tensor-co arrow-tensor-conversion-benchmark [.] arrow::SparseTensor::~SparseTensor + 9.15% 0.26% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::internal::IsTensorStridesContiguous + 7.76% 2.52% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::Tensor::CountNonZero + 7.25% 0.57% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::AllocateBuffer + 6.99% 6.99% arrow-tensor-co libc-2.27.so [.] cfree@GLIBC_2.2.5 + 6.99% 0.00% arrow-tensor-co libc-2.27.so [.] __GI___libc_free (inlined) + 6.76% 1.07% arrow-tensor-co libstdc++.so.6.0.27 [.] operator new + 6.03% 0.00% arrow-tensor-co libc-2.27.so [.] __GI___libc_malloc (inlined) + 5.73% 1.71% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::PoolBuffer::~PoolBuffer + 5.42% 1.35% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::SparseCOOIndex::SparseCOOIndex + 4.99% 0.41% arrow-tensor-co libarrow.so.100.0.0 [.] arrow::SparseCOOIndex::~SparseCOOIndex ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
