rymurr commented on pull request #7275: URL: https://github.com/apache/arrow/pull/7275#issuecomment-653444220
> Thanks for the quick update @rymurr , it looks pretty good! Only a couple minor things. I see quite a few instances of `offsetBuffer.getLong/setLong(i * OFFSET_WIDTH)` that I believe need to be cast to long to avoid overflow. Could you take a quick pass and fix those up? I think we will be good to go after that. Thanks for another thorough review @BryanCutler ! I think that I addressed everything. I may have went over the top w/ the casting but it doesn't hurt :-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
