jorisvandenbossche commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r449498839
##########
File path: python/pyarrow/tests/test_array.py
##########
@@ -583,12 +584,14 @@ def test_dictionary_from_numpy():
assert d2.dictionary.to_pylist() == dictionary.tolist()
for i in range(len(indices)):
+ assert d1[i].dictionary == dictionary
assert d1[i].as_py() == dictionary[indices[i]]
- if mask[i]:
- assert d2[i] is pa.NULL
- else:
- assert d2[i].as_py() == dictionary[indices[i]]
+ print(i, d2[i])
+ # if mask[i]:
+ # assert d2[i].as_py() is None
+ # else:
+ # assert d2[i].as_py() == dictionary[indices[i]]
Review comment:
left-over ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
