wesm commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r449802099
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -259,6 +259,27 @@ Result<Datum> IsValid(const Datum& values, ExecContext*
ctx = NULLPTR);
ARROW_EXPORT
Result<Datum> IsNull(const Datum& values, ExecContext* ctx = NULLPTR);
+struct ARROW_EXPORT FillNullOptions : public FunctionOptions {
+ explicit FillNullOptions(Datum fill_value) :
fill_value(std::move(fill_value)) {}
+
+ Datum fill_value;
+};
Review comment:
See comments above. I think this should be implemented as a binary
function since the "fill values" could be provided by an array. This also will
allow the execution layer to (in the near future) insert implicit casts where
needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
