kiszk commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450283575
##########
File path: cpp/src/arrow/testing/random.h
##########
@@ -140,6 +140,17 @@ class ARROW_TESTING_EXPORT RandomArrayGenerator {
std::shared_ptr<Array> Int64(int64_t size, int64_t min, int64_t max,
double null_probability = 0);
+ /// \brief Generates a random HalfFloatArray
+ ///
+ /// \param[in] size the size of the array to generate
+ /// \param[in] min the lower bound of the uniform distribution
+ /// \param[in] max the upper bound of the uniform distribution
Review comment:
Good point. It will not be uniform distribution for float16
Should I only update the comment? Or, should I create uniform distribution
float16 random while the current std does not support float16?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
