pitrou commented on a change in pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#discussion_r451424769
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -145,8 +145,148 @@ TYPED_TEST(TestStringKernels, Utf8Lower) {
CallFunction("utf8_lower", {invalid_input}));
}
+TYPED_TEST(TestStringKernels, IsAlphaNumericUnicode) {
+ // U+08BE (utf8: \xE0\xA2\xBE) is undefined, but utf8proc things it is
+ // UTF8PROC_CATEGORY_LO
+ this->CheckUnary("string_isalnum_unicode", "[\"ⱭɽⱤoW123\", null, \"Ɑ2\",
\"!\", \"\"]",
Review comment:
I would expect tests with non-alphanumeric characters, e.g. do we get
true or false for "some text"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
