rymurr commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r452086650
##########
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##########
@@ -812,12 +757,17 @@ public int getValueCount() {
}
public boolean isNull(int index) {
Review comment:
I am ok with changing this to always return false. However I think this
means anyone using a Union vector would have to extract the child and check for
null as an extra step. All other nested vectors have a top level validity
buffer. I don't know what the ramifications of changing this are?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
