lidavidm commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r452172011
##########
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##########
@@ -812,12 +757,17 @@ public int getValueCount() {
}
public boolean isNull(int index) {
Review comment:
I think from the viewpoint of code generically manipulating vectors,
this makes more sense - the entries of the union are never null, but they may
reference something that is null. I agree it's less convenient when working
with a union array explicitly though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
