BryanCutler commented on a change in pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#discussion_r452341314
##########
File path:
java/memory/memory-core/src/main/java/org/apache/arrow/memory/DefaultAllocationManagerOption.java
##########
@@ -114,10 +114,20 @@ static AllocationManagerType
getDefaultAllocationManagerType() {
}
private static AllocationManager.Factory getUnsafeFactory() {
- return getFactory("org.apache.arrow.memory.UnsafeAllocationManager");
+ try {
+ return getFactory("org.apache.arrow.memory.UnsafeAllocationManager");
+ } catch (RuntimeException e) {
+ throw new RuntimeException("Please add arrow-memory-unsafe to your
classpath," +
+ " No DefaultAllocationManager found to instantiate an
UnsafeAllocationManager", e);
+ }
}
private static AllocationManager.Factory getNettyFactory() {
- return getFactory("org.apache.arrow.memory.NettyAllocationManager");
+ try {
+ return getFactory("org.apache.arrow.memory.NettyAllocationManager");
+ } catch (RuntimeException e) {
+ throw new RuntimeException("Please add arrow-memory-unsafe to your
classpath," +
Review comment:
should be `arrow-memory-netty` and `NettyAllocationManager` below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
