wesm commented on a change in pull request #7696:
URL: https://github.com/apache/arrow/pull/7696#discussion_r452471124



##########
File path: docs/source/developers/cpp/building.rst
##########
@@ -347,6 +352,50 @@ You can then invoke CMake to create the build directory 
and it will use the
 declared environment variable pointing to downloaded archives instead of
 downloading them (one for each build dir!).
 
+Statically Linking
+~~~~~~~~~~~~~~~~~~
+
+Static linking the Arrow libraries can be tricky depending on your build

Review comment:
       "Tricky" is too much of an editorialization. It's accurate to say that 
it "may require an extra step beyond `find_project(Arrow)` in CMake". Will 
update

##########
File path: cpp/examples/minimal_build/Dockerfile
##########
@@ -22,5 +22,6 @@ ENV DEBIAN_FRONTEND=noninteractive
 RUN apt-get update -y -q && \
     apt-get install -y -q --no-install-recommends \
       build-essential \
-      cmake && \
+      cmake \
+      ninja-build && \

Review comment:
       Yes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to