wesm commented on a change in pull request #7664:
URL: https://github.com/apache/arrow/pull/7664#discussion_r452565269
##########
File path: python/pyarrow/ipc.pxi
##########
@@ -18,6 +18,32 @@
import warnings
+cpdef enum MetadataVersion:
+ V1 = <char> CMetadataVersion_V1
+ V2 = <char> CMetadataVersion_V2
+ V3 = <char> CMetadataVersion_V3
+ V4 = <char> CMetadataVersion_V4
+ V5 = <char> CMetadataVersion_V5
+
+
+cdef object _wrap_metadata_version(CMetadataVersion version):
+ return MetadataVersion(<char> version)
Review comment:
See
https://github.com/apache/arrow/blob/maint-0.17.x/cpp/src/arrow/ipc/message.cc#L57
So it only checks for old versions but new versions pass silently, which is
quite scary to me. But on the other hand the risk of V5 data breaking a V4
application (e.g. Spark) at the moment is low.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
