emkornfield commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-656491324
@tianchen92 rereading, after rereading all the comments. I think we should 1. Remove setReaderWriterIndeces in getFieldBuffers 2. Deprecate getBuffers 3. Introduce a new getIpcBuffers which is unambiguously used for writing record batches (i.e. in VectorUnloader). 4. Update documentation where it makes sense based on all this conversation. @jacques-n or someone else from dremio can maybe provide additional insight into how getBuffers is used and whether we really need to keep it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
