wesm edited a comment on pull request #7696:
URL: https://github.com/apache/arrow/pull/7696#issuecomment-656890077


   > I still think that "-DARROW_DEPENDENCY_SOURCE=SYSTEM" should work with 
arrow-static.
   > For this case my opinion is that non-vendored dependencies should not be 
bundled. Normally I want use the SYSTEM libraries for dependencies. As a 
developer of a third-party I do not want arrow to add symbols it does not own 
to my static linking process.
   
   @tobim our build system does not select static libraries when using 
`-DARROW_DEPENDENCY_SOURCE=SYSTEM` so they would not be bundled in 
`libarrow_bundled_dependencies.a`. That's kind of the whole point of this PR -- 
only add static libraries to `libarrow_bundled_dependencies.a` that the Arrow 
build system built itself. 
   
   If `arrow_static` has shared library dependencies on system libraries, then 
some other approach will be required to inform CMake automatically when doing 
`find_package(Arrow)`. It's definitely out of the scope for this PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to