wesm commented on a change in pull request #7668:
URL: https://github.com/apache/arrow/pull/7668#discussion_r453081425
##########
File path: r/R/array.R
##########
@@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) {
nrows <- x$num_rows %||% x$length() # Depends on whether Array or Table-like
if (inherits(i, "array_expression")) {
# Evaluate it
+ # Switch this when https://issues.apache.org/jira/browse/ARROW-9380 is
resolved
+ # i <- eval_array_expression(i)
Review comment:
When uncommenting this I get this failure
```
══ Failed
══════════════════════════════════════════════════════════════════════
── 1. Error: filter() with %in% (@test-dplyr.R#149)
───────────────────────────
'match' requires vector arguments
Backtrace:
1. arrow:::expect_dplyr_equal(...) testthat/test-dplyr.R:149:2
2. dplyr::filter(., dbl > 2, chr %in% c("d", "f"))
10. dplyr::collect(.)
14. arrow:::`[.RecordBatch`(...)
15. arrow:::filter_rows(x, i, ...)
16. arrow:::eval_array_expression(i)
17. base::lapply(...)
18. arrow:::FUN(X[[i]], ...)
19. arrow:::eval_array_expression(a)
21. <environment> %in% c("d", "f")
══ DONE
════════════════════════════════════════════════════════════════════════
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
