sunchao commented on pull request #7176: URL: https://github.com/apache/arrow/pull/7176#issuecomment-656898683
Just took another look. If we are going with this, we can potentially make the API simpler. For instance, current it is: ```rust fn next_row_group(&mut self) -> Result<Box<RowGroupWriter + '_>>; ``` As the returned box already is tracked by non-static lifetime, we can perhaps change the API to: ```rust fn next_row_group(&mut self) -> Result<&mut RowGroupWriter>; ``` and track the current group writer within the file writer. With this we can also potentially remove `close_row_group`. Similar things can be done for column writer. We can do this in a separate PR though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org