emkornfield commented on a change in pull request #7704:
URL: https://github.com/apache/arrow/pull/7704#discussion_r453148683
##########
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##########
@@ -2877,11 +2877,22 @@ TEST(TestArrowReaderAdHoc,
LARGE_MEMORY_TEST(LargeStringColumn)) {
array.reset();
auto reader =
ParquetFileReader::Open(std::make_shared<BufferReader>(tables_buffer));
-
std::unique_ptr<FileReader> arrow_reader;
ASSERT_OK(FileReader::Make(default_memory_pool(), std::move(reader),
&arrow_reader));
ASSERT_OK_NO_THROW(arrow_reader->ReadTable(&table));
ASSERT_OK(table->ValidateFull());
+
+ // ARROW-9297: ensure RecordBatchReader also works
+ reader =
ParquetFileReader::Open(std::make_shared<BufferReader>(tables_buffer));
+ ASSERT_OK(FileReader::Make(default_memory_pool(), std::move(reader),
&arrow_reader));
+ std::shared_ptr<::arrow::RecordBatchReader> batch_reader;
+ auto all_row_groups =
::arrow::internal::Iota(reader->metadata()->num_row_groups());
Review comment:
Could this be simplified to:
`::arrow::internal::Iota all_row_groups(...);
if so please do it. If not please spell out the type instead of auto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
