pitrou commented on a change in pull request #7753:
URL: https://github.com/apache/arrow/pull/7753#discussion_r454441837
##########
File path: python/pyarrow/jvm.py
##########
@@ -43,9 +43,14 @@ def jvm_buffer(arrowbuf):
pyarrow.Buffer
Python Buffer that references the JVM memory.
"""
+ import jpype
address = arrowbuf.memoryAddress()
size = arrowbuf.capacity()
- return pa.foreign_buffer(address, size, arrowbuf.asNettyBuffer())
+
+ # TODO: why can we not use arrowbuf as the base?
Review comment:
Well, it should be even easier with `pa.foreign_buffer`. Just pass a
custom base object with the desired destructor...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
