sunchao commented on pull request #7751:
URL: https://github.com/apache/arrow/pull/7751#issuecomment-660286242
Right. I think this case is impossible as Parquet don't support it. Also the
change you made for this case:
```rust
(ArrowType::Date64(unit), PhysicalType::INT64) => match unit
{
DateUnit::Millisecond => Date64Converter::new()
.convert(self.record_reader.cast::<Int64Type>()),
_ => Err(general_err!("No conversion from parquet type
to arrow type for date with unit {:?}", unit)),
```
will never happen as we'll never convert Parquet's INT64 to Arrow's Date64.
I think we just need the change for Date32.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
