andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r458804968
########## File path: rust/datafusion/src/execution/physical_plan/expressions.rs ########## @@ -47,81 +47,43 @@ use arrow::compute::kernels::sort::{SortColumn, SortOptions}; use arrow::datatypes::{DataType, Schema, TimeUnit}; use arrow::record_batch::RecordBatch; -/// Represents an aliased expression Review comment: I don't think we can remove alias from the logical plan. I would expect to see `expr AS alias` in the logical plan when I view it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org