jorgecarleitao commented on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-663376201
@andygrove , this is IMO now ready. There were two errors that I fixed in two separate commits: * 3503c0d fixed an error caused by a mistake of mine * ff3ade9 fixed an error in one of the tests The first one was related to the need of adding a projection when the order of SELECT is different from [groups] + [aggregates] in a group by. The current code has this and I had removed that part by mistake in this PR. Also, since this was only being tested in the integration tests, I have added a new test on the library to validate the logical plan. The second issue is IMO an error in one of the tests: it was parsing `SELECT c2, MIN(c12), MAX(c12) FROM aggregate_test_100 GROUP BY c1` as a valid statement and interpreting that statement as `c2` representing `c1`. With this PR, that is identified as an error because `c2` is not a valid column name in this context. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
