jorgecarleitao commented on a change in pull request #7687:
URL: https://github.com/apache/arrow/pull/7687#discussion_r463919728
##########
File path: rust/datafusion/src/execution/physical_plan/hash_aggregate.rs
##########
@@ -327,120 +278,47 @@ impl RecordBatchReader for GroupedHashAggregateIterator {
})
.collect::<ArrowResult<Vec<_>>>()?;
- // create vector large enough to hold the grouping key
+ // create vector to hold the grouping key
let mut key = Vec::with_capacity(group_values.len());
for _ in 0..group_values.len() {
- key.push(GroupByScalar::UInt32(0));
+ key.push(KeyScalar::UInt32(0));
}
// iterate over each row in the batch and create the accumulators
for each grouping key
- let mut accumulators: Vec<Rc<AccumulatorSet>> =
Review comment:
Actually, this information is incorrect. My CPU family is [Kaby
Lake](https://en.wikipedia.org/wiki/Kaby_Lake), which as the AVX2.0 extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
