kou commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r464009266
##########
File path: cpp/cmake_modules/Findzstd.cmake
##########
@@ -54,10 +54,11 @@ else()
if(ZSTD_PC_FOUND)
set(ZSTD_INCLUDE_DIR "${ZSTD_PC_INCLUDEDIR}")
- if(NOT ARROW_ZSTD_USE_SHARED)
+ if(ARROW_ZSTD_USE_SHARED)
+ list(APPEND ZSTD_PC_LIBRARY_DIRS "${ZSTD_PC_LIBDIR}")
+ else()
Review comment:
It seems that `XXX_STATIC_LIBDIR` is never defined:
https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L566
`_pkg_get_variable` doesn't set `XXX_STATIC_YYY`:
https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L566
(`XXX_LIBDIR` is only defined.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
