emkornfield commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r464023290
##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##########
@@ -101,4 +101,29 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
+TEST(TestArithmeticOps, TestBitwiseOps) {
+ // bitwise AND
+ EXPECT_EQ(bitwise_and_int32_int32(5245, 94553), 4185);
Review comment:
Using integer values for testing bitwise operations is hard to read and
verify could you use hex values instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
