emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r464573782
##########
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##########
@@ -101,4 +101,10 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
+TEST(TestArithmeticOps, TestRound) {
+ EXPECT_EQ(round_int32(758, -1), 760);
Review comment:
test cases should cover negative numbers, and boundary conditions (i.e.
.5 5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
