sbinet commented on a change in pull request #7752:
URL: https://github.com/apache/arrow/pull/7752#discussion_r465026675
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -30,6 +30,7 @@ import (
var (
Records = make(map[string][]array.Record)
+ PrettyJsons = make(map[string]string)
Review comment:
```suggestion
PrettyJSONs = make(map[string]string)
```
(if we follow Go conventions.)
also: do we need to export it?
it seems it's only used in tests. we should probably define that `map` in
the according `_test.go` file.
then it would make sense to rename it into `wantJSON`.
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -256,6 +1037,352 @@ func makeStructsRecords() []array.Record {
return recs
}
+func makeStructsPrettyJsons() string {
Review comment:
```suggestion
func makeStructsPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -503,6 +2189,733 @@ func makeFixedWidthTypesRecords() []array.Record {
return recs
}
+func makeFixedWidthTypesPrettyJsons() string {
Review comment:
```suggestion
func makeFixedWidthTypesPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -363,6 +1718,163 @@ func makeFixedSizeListsRecords() []array.Record {
return recs
}
+func makeFixedSizeListsPrettyJsons() string {
Review comment:
```suggestion
func makeFixedSizeListsPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -313,6 +1440,234 @@ func makeListsRecords() []array.Record {
return recs
}
+func makeListsPrettyJsons() string {
Review comment:
```suggestion
func makeListsPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -641,6 +3340,284 @@ func makeDurationsRecords() []array.Record {
return recs
}
+func makeDurationsPrettyJsons() string {
Review comment:
```suggestion
func makeDurationsPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -690,6 +3667,10 @@ func makeDecimal128sRecords() []array.Record {
return recs
}
+func makeDecimal128sPrettyJsons() string {
Review comment:
```suggestion
func makeDecimal128sPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -95,6 +108,52 @@ func makeNullRecords() []array.Record {
return recs
}
+func makeNullPrettyJsons() string {
Review comment:
```suggestion
func makeNullPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -178,6 +237,728 @@ func makePrimitiveRecords() []array.Record {
return recs
}
+func makePrimitivePrettyJsons() string {
Review comment:
```suggestion
func makePrimitivePrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -402,6 +1914,180 @@ func makeStringsRecords() []array.Record {
return recs
}
+func makeStringsPrettyJsons() string {
Review comment:
```suggestion
func makeStringsPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -584,6 +3086,203 @@ func makeIntervalsRecords() []array.Record {
return recs
}
+func makeIntervalsPrettyJsons() string {
Review comment:
```suggestion
func makeIntervalsPrettyJSON() string {
```
##########
File path: go/arrow/internal/arrdata/arrdata.go
##########
@@ -542,6 +2955,95 @@ func makeFixedSizeBinariesRecords() []array.Record {
return recs
}
+func makeFixedSizeBinariesPrettyJsons() string {
Review comment:
```suggestion
func makeFixedSizeBinariesPrettyJSON() string {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
