andygrove commented on a change in pull request #7899:
URL: https://github.com/apache/arrow/pull/7899#discussion_r465060246
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -259,6 +260,11 @@ impl ExecutionContext {
self.datasources.insert(name.to_string(), provider);
}
+ /// Get a reference to the registered data sources
Review comment:
Since we already have a `table` method for accessing a registered data
source, I wonder if it would be better to add a method to get a list of
registered table names:
```rust
pub fn tables(&self) -> Result<Vec<String>>
```
This would avoid exposing the internal hash map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
