kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465252291
##########
File path: cpp/src/arrow/ipc/reader.cc
##########
@@ -449,7 +449,7 @@ Result<std::shared_ptr<RecordBatch>> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_ptr<Schema>&
schema,
const std::vector<bool>& inclusion_mask, const DictionaryMemo*
dictionary_memo,
const IpcReadOptions& options, MetadataVersion metadata_version,
- Compression::type compression, io::RandomAccessFile* file) {
+ Compression::type compression, io::RandomAccessFile* file, bool
swap_endian = false) {
Review comment:
From a technical perspective, we can naively put `native_endian` into
`IpcReadOptions` in `reader.cc`.
From a semantics perspective, now, `native_endian` is to show the state on
whether the endianness in the schema is equal to the endianness of the CPU.
Since values in `IpcReadOptions` can be set by users, its flag should be like
`force_naive_endian` to ask to change the endianness of the schema.
If we put `force_naive_endian` in `IpcReadOptions`, we need to keep
`native_endian` somewhere.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
