liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-669111978
> At the very least I think this needs more comments as to why it appears that manual serializion of flatbuffer data is being used. > > It would also be nice to avoid introducing (if (x == null)) checks if at all possible, instead having default implementations would be better (unless there is a real performance reason for doing this). Avoid writing out compression settings when there are none seems like it could handled in the reverse direction (by checking for things that are non compressed and avoiding writing it out. @emkornfield Thanks a lot for your valuable feedback. As you have indicated, many of the problems are caused by 1) manual serilization and 2) no default compression codec. I have revised the PR to the fix above problems, so some other problems also go away. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
