pitrou commented on a change in pull request #7868:
URL: https://github.com/apache/arrow/pull/7868#discussion_r465810996
##########
File path: python/pyarrow/table.pxi
##########
@@ -425,31 +438,35 @@ def chunked_array(arrays, type=None):
Array arr
vector[shared_ptr[CArray]] c_arrays
shared_ptr[CChunkedArray] sp_chunked_array
- shared_ptr[CDataType] sp_data_type
+
+ type = ensure_type(type, allow_none=True)
if isinstance(arrays, Array):
arrays = [arrays]
for x in arrays:
- if isinstance(x, Array):
- arr = x
- if type is not None:
- assert x.type == type
+ arr = x if isinstance(x, Array) else array(x, type=type)
+
+ if type is None:
+ # it allows more flexible chunked array construction from to coerce
+ # subsequent arrays to the firstly inferred array type
+ # it also spares the inference overhead after the first chunk
+ type = arr.type
else:
- arr = array(x, type=type)
+ if arr.type != type:
+ raise ArrowInvalid(
+ "Each array chunks must have type {}".format(type)
Review comment:
Either "All array chunks" (plural) or "Each array chunk" (singular).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
