trxcllnt commented on pull request #7909: URL: https://github.com/apache/arrow/pull/7909#issuecomment-670138897
@pitrou I'm not a huge fan of the changes in this PR, but they seemed like the least invasive option considering the alternatives: * Avoided using `ViewOrCopy` because that could lead to many small/expensive device-to-host reads * Tried to avoid disabling validation, as Schema and Array/Buffer length/offset/size checks are still beneficial Additionally, setting the raw pointers to null in the two `Array::SetData` implementations is the easiest way to ensure no host routines attempt to read the underlying data (otherwise, we'd have to go through and update all the reads to use `ViewOrCopy`). That'd probably be a nice thing to do from a usability perspective, but more work than I have time to do before 1.0.1. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
